Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42143 )
Change subject: mb/google/poppy: Add retail names ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG@9 PS1, Line 9: Looks like nami encompasses : many different devices, which would not fit in one line, so skip it.
would it make sense to add a few new board aliases that just select BOARD_GOOGLE_NAMI so that all th […]
We can't really select BOARD_GOOGLE_NAMI because it's a symbol in a prompt. We'd need to have separate symbols that are then handled the same. Sure, we could simply have those select a BOARD_GOOGLE_NAMI symbol that is not inside Kconfig.name, but I'd prefer to do that kind of surgery in a separate change.