Attention is currently required from: Eric Lai, Lean Sheng Tan, Matt DeVillier, Nick Vaccaro, Subrata Banik, Werner Zeh.
Hello Eric Lai, Lean Sheng Tan, Nick Vaccaro, Subrata Banik, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78825?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+2 by Eric Lai
Change subject: soc/intel/*: Correct ACPI device name for eMMC ......................................................................
soc/intel/*: Correct ACPI device name for eMMC
The ACPI name of any device needs to match the name used for generating the S0i3 LPI constraint list, which comes from soc_acpi_name() for each SoC. The names used for the eMMC controller do not match, which will lead to broken ACPI tables since the LPI constriant will reference an ACPI device which does not exist. Some OSes tolerate this better than others, but it should still be corrected.
TEST=build/boot google/{hatch,volteer, brya}, dump ACPI and verify no invalid device names referenced.
Change-Id: Icbc22b6b2a84bbe73f1b09083f27081612db5eba Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/alderlake/acpi/scs.asl M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/elkhartlake/acpi/scs.asl M src/soc/intel/jasperlake/acpi/scs.asl 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/78825/2