Attention is currently required from: Bora Guvendik, Cliff Huang, Jeremy Compostella, Subrata Banik, Tim Wawrzynczak.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63943 )
Change subject: soc/intel/alderlake: add support for external source clock
......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63943/comment/7c9b15ec_41a8b22a
PS6, Line 9: includingsource
missing space.
Done
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63943/comment/2b14f830_2fdb5630
PS6, Line 239: default 10 if SOC_INTEL_ALDERLAKE_PCH_P
Why do you change the line ? Couldn't you just change the value ?
Change was done to the same line, but SOC_INTEL_ALDERLAKE_PCH_S got merged then.
https://review.coreboot.org/c/coreboot/+/63943/comment/e1be5844_be51a0e7
PS6, Line 241: 3
three
Done
https://review.coreboot.org/c/coreboot/+/63943/comment/638630dd_1c8f28c0
PS6, Line 241: clock
clocks
Done
https://review.coreboot.org/c/coreboot/+/63943/comment/a6ac3ecb_8417f863
PS6, Line 242: This done
This is done
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0296974fb8557de1edea7f9ca2d96db0afd8a743
Gerrit-Change-Number: 63943
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 20:56:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-MessageType: comment