Attention is currently required from: Nico Huber, Stefan Reinauer, Angel Pons, Julius Werner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51177 )
Change subject: libpayload: Enable LTO by default
......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS12:
+1 to this concern.
I can only test with QEMU, and tested with coreinfo.
FILO currently hangs with an emulated USB device without and with LTO.
If you can tell me how to test it further, please tell me. Otherwise, it should go in early in the release cycle, so it gets more exposure.
PS12:
If it's enabled by default, no config to test LTO is needed, but then the problem is that things may […]
Ok, then it was a misunderstanding in the meeting, as the commit is about enabling it by default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51177
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc58034ea8a9510ddc08d61d19e75a7c6f9cbc7
Gerrit-Change-Number: 51177
Gerrit-PatchSet: 13
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 14 Nov 2022 22:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment