Attention is currently required from: Paul Menzel, Angel Pons.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 )
Change subject: arch/x86/smbios: Fix file formatting
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74170/comment/d0ba7cf5_a49622da
PS2, Line 216: dimm->serial[1], dimm->serial[2], dimm->serial[3]);
Utkarsh, just to let you know, that clang-format is not used yet in coreboot properly, so it might b […]
Thanks, Paul. I think I'll be interested in working towards `.clang-format` improvement. Hence, I'll try to modify it and update this patch until `clang-format` can provide something you guys are okay with. There is a possibility of this being a dead end too, but I'll see.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40f44eec4d14d8b905f438c5305b640a33408c45
Gerrit-Change-Number: 74170
Gerrit-PatchSet: 3
Gerrit-Owner: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 23:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-MessageType: comment