[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Update SD card GPIO settings - coreboot-gerrit

13 Oct 2023


      Attention is currently required from: Nick Vaccaro, Paul Menzel, Robert Chen, Shawn Ku, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78253?usp=email )
Change subject: mb/google/nissa/var/quandiso: Update SD card GPIO settings
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/quandiso/gpio.c:
https://review.coreboot.org/c/coreboot/+/78253/comment/c2465a45_c1d0f940 :
PS4, Line 93: 	PAD_CFG_GPO(GPP_H12, 1, DEEP),
...
Set high GPP_H12 first is refer from neried and yaviks that same design with SD_CARD. […]
okay I see in early table is low. LGTM.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6789d42b9a3f9b979fd481a88cc7d69db2dcfe
Gerrit-Change-Number: 78253
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku shawnku@chromium.org
Gerrit-Reviewer: Shawn Ku shawnku@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shawn Ku shawnku@chromium.org
Gerrit-Comment-Date: Fri, 13 Oct 2023 03:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai ericllai@google.com
Comment-In-Reply-To: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-MessageType: comment