[S] Change in coreboot[master]: soc/amd/mendocino: Force resets to be cold

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Tim Van Patten, Fred Reitberger.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72486 )

Change subject: soc/amd/mendocino: Force resets to be cold
......................................................................

Patch Set 3:

(1 comment)

File src/soc/amd/mendocino/fch.c:

https://review.coreboot.org/c/coreboot/+/72486/comment/877ae74a_cd611567 
PS3, Line 131: 	pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | TOGGLE_ALL_PWR_GOOD);
> It sounds like `fch_init_resets()` should be dropped from this CL then, since we aren't doing warm r […]

no, fch_init_resets is essential to make sure that that bit to change the reset behavior is still set in the case when coreboot doesn't do a reset which should be the main case. i'd still set this bit in the do_*_rest functions, so that those also behave correctly before the fch_init_resets call