Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Rob Barnes, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59017 )
Change subject: soc/amd/psp_verstage: Get vb2_context early ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/59017/comment/67163e9a_69e9d891 PS1, Line 224:
If map_fch_devices completely fails I don't think there's anything to do with our recovery process, […]
Yeah, since this is super early in RO code, I don't think there is anything we can do... We can't really go into recovery since it would just execute this code again...
We can't even print a post code using svc_write_postcode since we don't have eSPI setup... Maybe we just `svc_exit`? This should cause RO bootblock to run I think. RO boot block will then fail since there is no transfer buffer.
I did notice that svc_write_postcode is not implemented for cezanne: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
Is that something we are planning on fixing?
-
Raul Rangel (Code Review)