Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68559 )
Change subject: soc/amd: move all AOAC function prototypes to amdblocks/aoac.h
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/aoac.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160717):
https://review.coreboot.org/c/coreboot/+/68559/comment/9dd23eb5_373789ab
PS3, Line 38: /* the following 2 functons are implemented in the SoC code */
'functons' may be misspelled - perhaps 'functions'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3deae150cd1e20fff6507a0f0ba6a375fca430e5
Gerrit-Change-Number: 68559
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 18 Oct 2022 22:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment