Change in coreboot[master]: .gitignore: Exclude '*.fd'

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

.gitignore: Exclude '*.fd'

These files are usually binaries, and should never be committed.

Change-Id: I9df80f777020632e4c82a06ae3ae73c95234f3b5
Signed-off-by: Angel Pons 
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46322/1

diff --git a/.gitignore b/.gitignore
index 2fabfee..97cc9ce 100644
--- a/.gitignore
+++ b/.gitignore
@@ -59,6 +59,7 @@
 *.debug
 !Kconfig.debug
 *.elf
+*.fd
 *.o
 *.o.d
 *.out

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 1:

I know the commit message could be better, but I don't have any better ideas atm.

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 1: Code-Review+1

seems reasonable to me

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46322/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46322/1//COMMIT_MSG@7 
PS1, Line 7: .gitignore: Exclude '*.fd'
Just a side note, that it’s ambiguous, as it’s not clear if the pattern is removed (excluded) from the file `.gitignore` or from git’s tracking. Maybe:
> .gitignore: Ignore `*.fd`
> .gitignore: Do not let git track `*.fd`

It’s a nit, so I mark it as resolved.

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Matt DeVillier, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46322

to look at the new patch set (#2).

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

.gitignore: Do not let git track '*.fd'

These files are usually binaries, and should never be committed.

Change-Id: I9df80f777020632e4c82a06ae3ae73c95234f3b5
Signed-off-by: Angel Pons 
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46322/2

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46322/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46322/1//COMMIT_MSG@7 
PS1, Line 7: .gitignore: Exclude '*.fd'
> Just a side note, that it’s ambiguous, as it’s not clear if the pattern is removed (excluded) from t […]

Thanks, done.

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Matt DeVillier, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46322

to look at the new patch set (#3).

Change subject: .gitignore: Exclude '*.fd'
......................................................................

.gitignore: Exclude '*.fd'

These files are usually binaries, and should never be committed.

Change-Id: I9df80f777020632e4c82a06ae3ae73c95234f3b5
Signed-off-by: Angel Pons 
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46322/3

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 3: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 3:

Just a note, that the old commit message summary was uploaded again.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Exclude '*.fd'
......................................................................

Patch Set 3:
> Patch Set 3:
>
> Just a note, that the old commit message summary was uploaded again.

D'oh, that must be because it's in my local tree...

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Matt DeVillier, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46322

to look at the new patch set (#5).

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

.gitignore: Do not let git track '*.fd'

These files are usually binaries, and should never be committed.

Change-Id: I9df80f777020632e4c82a06ae3ae73c95234f3b5
Signed-off-by: Angel Pons 
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46322/5

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

Patch Set 4:
> Patch Set 3:
> > Patch Set 3:
> >
> > Just a note, that the old commit message summary was uploaded again.
>
> D'oh, that must be because it's in my local tree...

Fixed. Thanks for noticing.

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

Patch Set 5:

I'm going to submit this before I accidentally push an old patchset again. It does not affect any code, thus can be considered trivial.

Change in coreboot[master]: .gitignore: Do not let git track '*.fd'

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46322 )

Change subject: .gitignore: Do not let git track '*.fd'
......................................................................

.gitignore: Do not let git track '*.fd'

These files are usually binaries, and should never be committed.

Change-Id: I9df80f777020632e4c82a06ae3ae73c95234f3b5
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46322
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/.gitignore b/.gitignore
index 2fabfee..97cc9ce 100644
--- a/.gitignore
+++ b/.gitignore
@@ -59,6 +59,7 @@
 *.debug
 !Kconfig.debug
 *.elf
+*.fd
 *.o
 *.o.d
 *.out