Attention is currently required from: Tarun Tuli, Sridhar Siricilla, Angel Pons, Arthur Heymans, Eric Lai, Lean Sheng Tan.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69978 )
Change subject: soc/intel/cmn/cse: Allow to perform essential CSE operations post EOP
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/69978/comment/7bba2485_371865e3
PS5, Line 244: if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE))
: cse_late_finalize();
This code has to be decoupled or function name must be renamed to reflect new addition.
Please suggest the name ? any suggestion ?
Because of the below reasons, I haven't change the function name.
- Unless SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE, this function is still just sending the EOP alone.
- If SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE then this function additionally perform cse_late_finalize() (required post sending EOP)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69978
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c
Gerrit-Change-Number: 69978
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:25:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment