Change in coreboot[master]: util: Make sure all util dirs have description files at top level
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48961 )
Change subject: util: Make sure all util dirs have description files at top level ......................................................................
util: Make sure all util dirs have description files at top level
New util directories have been added with no description.md file. The description file for supermicro was added at a secondary level, which doesn't help a user find the util since no path was added. Move it up to the top level.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I40b4c25dd7706513e96c6b8078a34160f8bb901e --- A util/apcb/description.md A util/mainboard/description.md A util/qemu/description.md A util/spd_tools/description.md A util/supermicro/description.md D util/supermicro/smcbiosinfo/description.md 6 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/48961/1
diff --git a/util/apcb/description.md b/util/apcb/description.md new file mode 100644 index 0000000..674243a --- /dev/null +++ b/util/apcb/description.md @@ -0,0 +1,4 @@ +AMD PSP Control Block tools + +* _apcb_edit.py_ - This tool allows patching an existing APCB binary with + specific SPDs and GPIO selection pins. `Python3` diff --git a/util/mainboard/description.md b/util/mainboard/description.md new file mode 100644 index 0000000..4050a80 --- /dev/null +++ b/util/mainboard/description.md @@ -0,0 +1,3 @@ +mainboard specific scripts + +* _google_ - Directory for google mainboard specific scripts diff --git a/util/qemu/description.md b/util/qemu/description.md new file mode 100644 index 0000000..6e3a16c --- /dev/null +++ b/util/qemu/description.md @@ -0,0 +1,3 @@ +__qemu__ + +- Makefile & comprehensive default config for QEMU Q35 emulation diff --git a/util/spd_tools/description.md b/util/spd_tools/description.md new file mode 100644 index 0000000..aa12781 --- /dev/null +++ b/util/spd_tools/description.md @@ -0,0 +1,11 @@ +Tools for generating SPD files for DDR4 memory used in platforms with +memory down configuration. + + + +* _gen_spd.go_ - Generates de-duplicated SPD files using a + global memory part list provided by the + mainboard in JSON format. `Go` + +* _gen_part_id.go_ - Allocates DRAM strap IDs for different + DDR4 memory parts used by the board. `Go` diff --git a/util/supermicro/description.md b/util/supermicro/description.md new file mode 100644 index 0000000..8584016 --- /dev/null +++ b/util/supermicro/description.md @@ -0,0 +1,3 @@ +Tools for supermicro platforms + +* _smcbiosinfo_ - Generates SMC biosinfo for BMC BIOS updates `C` diff --git a/util/supermicro/smcbiosinfo/description.md b/util/supermicro/smcbiosinfo/description.md deleted file mode 100644 index 21170eb..0000000 --- a/util/supermicro/smcbiosinfo/description.md +++ /dev/null @@ -1 +0,0 @@ -Generates SMC biosinfo for BMC BIOS updates `C`
Tom Hiller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48961 )
Change subject: util: Make sure all util dirs have description files at top level ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48961 )
Change subject: util: Make sure all util dirs have description files at top level ......................................................................
util: Make sure all util dirs have description files at top level
New util directories have been added with no description.md file. The description file for supermicro was added at a secondary level, which doesn't help a user find the util since no path was added. Move it up to the top level.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I40b4c25dd7706513e96c6b8078a34160f8bb901e Reviewed-on: https://review.coreboot.org/c/coreboot/+/48961 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tom Hiller thrilleratplay@gmail.com --- A util/apcb/description.md A util/mainboard/description.md A util/qemu/description.md A util/spd_tools/description.md A util/supermicro/description.md D util/supermicro/smcbiosinfo/description.md 6 files changed, 24 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tom Hiller: Looks good to me, approved
diff --git a/util/apcb/description.md b/util/apcb/description.md new file mode 100644 index 0000000..674243a --- /dev/null +++ b/util/apcb/description.md @@ -0,0 +1,4 @@ +AMD PSP Control Block tools + +* _apcb_edit.py_ - This tool allows patching an existing APCB binary with + specific SPDs and GPIO selection pins. `Python3` diff --git a/util/mainboard/description.md b/util/mainboard/description.md new file mode 100644 index 0000000..4050a80 --- /dev/null +++ b/util/mainboard/description.md @@ -0,0 +1,3 @@ +mainboard specific scripts + +* _google_ - Directory for google mainboard specific scripts diff --git a/util/qemu/description.md b/util/qemu/description.md new file mode 100644 index 0000000..6e3a16c --- /dev/null +++ b/util/qemu/description.md @@ -0,0 +1,3 @@ +__qemu__ + +- Makefile & comprehensive default config for QEMU Q35 emulation diff --git a/util/spd_tools/description.md b/util/spd_tools/description.md new file mode 100644 index 0000000..aa12781 --- /dev/null +++ b/util/spd_tools/description.md @@ -0,0 +1,11 @@ +Tools for generating SPD files for DDR4 memory used in platforms with +memory down configuration. + + + +* _gen_spd.go_ - Generates de-duplicated SPD files using a + global memory part list provided by the + mainboard in JSON format. `Go` + +* _gen_part_id.go_ - Allocates DRAM strap IDs for different + DDR4 memory parts used by the board. `Go` diff --git a/util/supermicro/description.md b/util/supermicro/description.md new file mode 100644 index 0000000..8584016 --- /dev/null +++ b/util/supermicro/description.md @@ -0,0 +1,3 @@ +Tools for supermicro platforms + +* _smcbiosinfo_ - Generates SMC biosinfo for BMC BIOS updates `C` diff --git a/util/supermicro/smcbiosinfo/description.md b/util/supermicro/smcbiosinfo/description.md deleted file mode 100644 index 21170eb..0000000 --- a/util/supermicro/smcbiosinfo/description.md +++ /dev/null @@ -1 +0,0 @@ -Generates SMC biosinfo for BMC BIOS updates `C`
-
Martin Roth (Code Review) -
Patrick Georgi (Code Review)
-
Tom Hiller (Code Review)