Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41720 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 0 firmware version by VPD variable
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41720/11/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/41720/11/src/mainboard/ocp/deltalak...
PS11, Line 79: const char *smbios_mainboard_bios_version(void)
this feature would be useful beyond just DeltaLake. […]
I added the implementation to drivers/vpd in CB:42029.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98a8fe1135728f31ec154d6340d19be8d8f980ba
Gerrit-Change-Number: 41720
Gerrit-PatchSet: 11
Gerrit-Owner: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: insomniac
insomniac@slackware.it
Gerrit-Comment-Date: Wed, 03 Jun 2020 04:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: insomniac
insomniac@slackware.it
Gerrit-MessageType: comment