Attention is currently required from: Felix Singer, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60600 )
Change subject: nb/intel/{sandybridge,haswell}: Rename PCIe driver ......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/sandybridge/pcie.c:
https://review.coreboot.org/c/coreboot/+/60600/comment/0a3e44f5_3981c625 PS1, Line 66: sa_pcie
Just an idea: How about naming it "nb_pcie"? So it reflects the file path (src/northbridge/intel/... […]
I don't think it would help clarify the naming conundrum. Haswell code refers to these PCIe ports as PEG (PCI Express Graphics), and so does Sandy Bridge in ACPI (see `pcie_acpi_name()` function and ASL). Also, we don't have a `src/pch/intel/...` folder structure, yet the `pch_pcie` name is still there, even in i82801{i,j}x which are not PCHs! 😄
I'll leave it as-is for now, but I'll happily rename it if you want.
-
Angel Pons (Code Review)