Attention is currently required from: Martin Roth, Paul Menzel.
Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85493?usp=email )
Change subject: mb/amd/birman_plus: Kconfig ......................................................................
Patch Set 17:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85493/comment/c9c0caae_dc22e9d7?usp... : PS12, Line 7: mb/amd/birman_plus: Kconfig
Please make it a statement by adding a verb (in imperative mood).
Done
File src/mainboard/amd/birman_plus/port_descriptors_glinda.c:
https://review.coreboot.org/c/coreboot/+/85493/comment/89a16580_8255b208?usp... : PS8, Line 87: 14
So this is just ignored if it's set to disabled? I'd think we'd just want to the GBE/SD entries if W […]
Done
File src/mainboard/amd/birman_plus/port_descriptors_glinda.c:
https://review.coreboot.org/c/coreboot/+/85493/comment/4d244e41_816bf4e4?usp... : PS12, Line 42: \
Not sure what the rule is or if it is important, but should the backslash be aligned with the others […]
Done
https://review.coreboot.org/c/coreboot/+/85493/comment/f74c07d0_6f7f858a?usp... : PS12, Line 44: 15
Should this value depend on ENABLE_WLAN02_BIRMANPLUS like in patchset 8? Same for 2-lane WWAN
Done
-
Ana Carolina Cabral (Code Review)