Attention is currently required from: Arthur Heymans, Chen, Gang C, David Hendricks, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, TangYiwei.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81322?usp=email )
Change subject: mb/intel/beechnutcity_crb: Add GNR/SRF-SP 2S server board Beechnut City ......................................................................
Patch Set 11:
(2 comments)
File configs/builder/config.intel.crb.bnc:
https://review.coreboot.org/c/coreboot/+/81322/comment/14d2c67b_503622d6 : PS11, Line 27: # : CONFIG_IFD_BIN_PATH="site-local/beechnutcity/descriptor.bin" : CONFIG_CPU_UCODE_BINARIES="site-local/beechnutcity/ucode.mcb" : CONFIG_FSP_T_FILE="site-local/beechnutcity/Server_T.fd" : CONFIG_FSP_M_FILE="site-local/beechnutcity/Server_M.fd" : CONFIG_FSP_S_FILE="site-local/beechnutcity/Server_S.fd" : CONFIG_FSP_HEADER_PATH="src/vendorcode/intel/fsp/fsp2_0/graniterapids/sp/"
I'm not sure if upstream code should have references to site-local stuff?
This is aligned with configs/builder/config.intel.crb.ac, should it be okay?
File src/mainboard/intel/beechnutcity_crb/Kconfig:
https://review.coreboot.org/c/coreboot/+/81322/comment/91080fe3_55d2c305 : PS11, Line 8: select MAINBOARD_USES_FSP2_0
This should be removed (also from all other xeon_sp boards)
Sure, raised a new one for this, https://review.coreboot.org/c/coreboot/+/81783 and let us discuss there.