build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59937 )
Change subject: mb/intel/adlrvp: Configure GPIOs for Alder Lake-N ......................................................................
Patch Set 1:
(34 comments)
File src/mainboard/intel/adlrvp/gpio_n.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/7971b3ff_0660182f PS1, Line 9: /*ESPI_IO0_EC_R / ESPI_IO0_HDR*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/3bce52da_c3a7100c PS1, Line 10: PAD_CFG_NF(GPP_A0, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/42a47f04_156bbbb1 PS1, Line 10: PAD_CFG_NF(GPP_A0, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/311a0126_fa4e036c PS1, Line 11: /*ESPI_IO1_EC_R / ESPI_IO1_HDR*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/cd075286_782bf183 PS1, Line 12: PAD_CFG_NF(GPP_A1, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/3b72deed_4f9d86df PS1, Line 12: PAD_CFG_NF(GPP_A1, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/f809c1e8_5a353aaf PS1, Line 13: /*ESPI_IO2_EC_R / ESPI_IO2_HDR*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/2d3d7fab_5dc18907 PS1, Line 14: PAD_CFG_NF(GPP_A2, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/b0992747_5eabd42a PS1, Line 14: PAD_CFG_NF(GPP_A2, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/c98d7404_bef16fb2 PS1, Line 15: /*ESPI_IO3_EC_R / ESPI_IO3_HDR*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/fe9b2499_4971bc01 PS1, Line 16: PAD_CFG_NF(GPP_A3, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/744660d7_a16de988 PS1, Line 16: PAD_CFG_NF(GPP_A3, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/fd0fa982_73559493 PS1, Line 17: /*ESPI_CS0_EC_R_N / ESPI_CS0_HDR_N*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/164b634a_7c0a3db0 PS1, Line 18: PAD_CFG_NF(GPP_A4, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/a2784a49_b88e1c18 PS1, Line 18: PAD_CFG_NF(GPP_A4, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/49b5dda9_3eaafce4 PS1, Line 19: /*ESPI_ALERT0_EC_R_N / ESPI_ALERT0_HDR_N*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/6cea559c_b87c0f32 PS1, Line 20: PAD_CFG_NF(GPP_A5, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/afb73454_a204578a PS1, Line 20: PAD_CFG_NF(GPP_A5, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/dd2edefd_83cdf28b PS1, Line 21: /*ESPI_CLK_EC_R / ESPI_CLK_HDR*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/122da39e_12ace8af PS1, Line 22: PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/6d1c1e39_7adb55d8 PS1, Line 22: PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/07fed75c_29b8b879 PS1, Line 23: /*ESPI_RST_EC_R_N / ESPI_RST_HDR_N*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/065eb275_07462f3d PS1, Line 24: PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/e5f42732_ab59da18 PS1, Line 24: PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/5598be8b_7d2d0ac1 PS1, Line 134: PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/33e994bc_72028e23 PS1, Line 134: PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/b57ba518_414f75a3 PS1, Line 211: gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/25252736_874714d5 PS1, Line 211: gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/12b95d1a_181345c8 PS1, Line 215: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/29899232_6c5699b3 PS1, Line 215: CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/064e40c4_f73aab49 PS1, Line 220: *num = ARRAY_SIZE(cros_gpios); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/e50249f0_bcb9ba57 PS1, Line 220: *num = ARRAY_SIZE(cros_gpios); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/75fac8d0_0b704bf4 PS1, Line 221: return cros_gpios; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135051): https://review.coreboot.org/c/coreboot/+/59937/comment/661a24c6_423009dd PS1, Line 221: return cros_gpios; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)