HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41681 )
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
src: Remove unused 'include <fmap.h>'
Change-Id: I79eea0a00c2de54f82b372229381534707a295bb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/vpd/vpd_cbmem.c M src/security/vboot/vboot_common.c 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/41681/1
diff --git a/src/drivers/vpd/vpd_cbmem.c b/src/drivers/vpd/vpd_cbmem.c index eadda52..a13fb01 100644 --- a/src/drivers/vpd/vpd_cbmem.c +++ b/src/drivers/vpd/vpd_cbmem.c @@ -2,7 +2,6 @@
#include <console/console.h> #include <cbmem.h> -#include <fmap.h> #include <string.h> #include <timestamp.h>
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index 30a2c2f..1cddeeb 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -3,7 +3,6 @@ #include <boot_device.h> #include <cbmem.h> #include <console/cbmem_console.h> -#include <fmap.h> #include <reset.h> #include <security/vboot/misc.h> #include <security/vboot/vboot_common.h>
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41681 )
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41681
to look at the new patch set (#3).
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
src: Remove unused 'include <fmap.h>'
Change-Id: I79eea0a00c2de54f82b372229381534707a295bb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/vboot/vboot_common.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/41681/3
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41681 )
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41681 )
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41681 )
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
src: Remove unused 'include <fmap.h>'
Change-Id: I79eea0a00c2de54f82b372229381534707a295bb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41681 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/vboot_common.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index 30a2c2f..1cddeeb 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -3,7 +3,6 @@ #include <boot_device.h> #include <cbmem.h> #include <console/cbmem_console.h> -#include <fmap.h> #include <reset.h> #include <security/vboot/misc.h> #include <security/vboot/vboot_common.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41681 )
Change subject: src: Remove unused 'include <fmap.h>' ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4608 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4607 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4606 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4605
Please note: This test is under development and might not be accurate at all!