New patch to review for coreboot: ab64330 Remove CDIT table and DMI table of AMD f15tn and f16kb boards
WANG Siyuan (wangsiyuanbuaa@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4092
-gerrit
commit ab64330dfa0d01129e4024c7fe46770f7480a1e2 Author: WANG Siyuan wangsiyuanbuaa@gmail.com Date: Mon Nov 18 10:34:06 2013 +0800
Remove CDIT table and DMI table of AMD f15tn and f16kb boards
There is such kind error: ASSERTION FAILED: file 'src/mainboard/asrock/imb-a180/agesawrapper.c',line 431 DmiTable:100123f7, AcpiPstatein: 10010129,AcpiSrat:0,AcpiSlit:0, Mce:10010de9,Cmc:10010eab,Alib:1002111c, AcpiIvrs:0 in agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5
On f16kb boards, CDIT table and DMI table are failed to created. On f15tn boards, DMI table is failed to created.
We remove these tow tables before we find the root cause.
Thank Wei Hu for debugging and founding this issue.
Change-Id: I837e3c322bb5331a9b950a72397796a60642c3f3 Signed-off-by: WANG Siyuan SiYuan.Wang@amd.com Signed-off-by: WANG Siyuan wangsiyuanbuaa@gmail.com --- src/mainboard/amd/olivehill/buildOpts.c | 4 ++++ src/mainboard/amd/parmer/buildOpts.c | 3 +++ src/mainboard/amd/thatcher/buildOpts.c | 3 +++ src/mainboard/asrock/imb-a180/buildOpts.c | 4 ++++ src/mainboard/asus/f2a85-m/buildOpts.c | 3 +++ 5 files changed, 17 insertions(+)
diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c index 0528315..634cb32 100644 --- a/src/mainboard/amd/olivehill/buildOpts.c +++ b/src/mainboard/amd/olivehill/buildOpts.c @@ -61,6 +61,10 @@ #endif #endif
+/* remove CDIT and DMI table */ +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index d022ae7..9c4d17d 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -58,6 +58,9 @@
#define INSTALL_FM2_SOCKET_SUPPORT FALSE
+/* remove DMI table */ +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index aace5fd..fb709df 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -58,6 +58,9 @@
#define INSTALL_FM2_SOCKET_SUPPORT FALSE
+/* remove DMI table */ +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index d0aae25..965c3d1 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -61,6 +61,10 @@ #endif #endif
+/* remove CDIT and DMI table */ +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c index 7f893f9..5e2de39 100644 --- a/src/mainboard/asus/f2a85-m/buildOpts.c +++ b/src/mainboard/asus/f2a85-m/buildOpts.c @@ -58,6 +58,9 @@
#define INSTALL_FM2_SOCKET_SUPPORT TRUE
+/* remove DMI table */ +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_SODIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE
-
WANG Siyuan