Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32277
Change subject: mb/google/sarien: Enable board_id feature ......................................................................
mb/google/sarien: Enable board_id feature
Enable the Kconfig option to automatically read the board ID and populate it into the SMBIOS tables.
BUG=b:123261132 TEST=verify current board id from the OS: cat /sys/class/dmi/id/board_version rev1
Change-Id: Id41631bfaa627ca9d5034e2ebe93f8ace2ffdad8 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/sarien/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/32277/1
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 58ab300..9d658fa 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -9,6 +9,7 @@ select DRIVERS_USB_ACPI select EC_GOOGLE_WILCO select GENERIC_SPD_BIN + select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_LPSS_UART_FOR_CONSOLE
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32277 )
Change subject: mb/google/sarien: Enable board_id feature ......................................................................
Patch Set 1: Code-Review+2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32277 )
Change subject: mb/google/sarien: Enable board_id feature ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32277 )
Change subject: mb/google/sarien: Enable board_id feature ......................................................................
Patch Set 3: Code-Review+1
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32277 )
Change subject: mb/google/sarien: Enable board_id feature ......................................................................
mb/google/sarien: Enable board_id feature
Enable the Kconfig option to automatically read the board ID and populate it into the SMBIOS tables.
BUG=b:123261132 TEST=verify current board id from the OS: cat /sys/class/dmi/id/board_version rev1
Change-Id: Id41631bfaa627ca9d5034e2ebe93f8ace2ffdad8 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32277 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Lijian Zhao: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 58ab300..9d658fa 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -9,6 +9,7 @@ select DRIVERS_USB_ACPI select EC_GOOGLE_WILCO select GENERIC_SPD_BIN + select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_LPSS_UART_FOR_CONSOLE
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Lijian Zhao (Code Review)
-
Paul Menzel (Code Review)