Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58064 )
Change subject: soc/intel/common/../cse: Helper function to check CSE device `devfn` status
......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58064/comment/7278fa10_8c8ab75a
PS4, Line 7: soc/intel/common/../cse: Helper function to check CSE device `devfn` status
72 chars wide for summary please
https://review.coreboot.org/c/coreboot/+/58064/comment/ad76c677_b5ff1da9
PS4, Line 10: all
any
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/58064/comment/71cd6687_8109e83a
PS4, Line 156: `
missing space after `
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I208b07e89e3aa9d682837380809fbff01ea225b0
Gerrit-Change-Number: 58064
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 04 Oct 2021 16:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment