Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25416 )
Change subject: soc/intel/apollolake: Save/restore GMA OpRegion address
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25416/2/src/soc/intel/apollolake/gr...
File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/25416/2/src/soc/intel/apollolake/gr...
PS2, Line 43: }
Doesn't seem to be used. If all platforms implement it, we could call
it from intel_gma_init_igd_opregion(), I guess, and don't write `aslb`
below.
Shouldn't have looked at it... now I realize graphics_soc_write_acpi_opregion()
does nothing soc specific. I'll try to get rid of it later :-/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4123998b0ab3c263c6a9ff14084a0d8808e5f4cd
Gerrit-Change-Number: 25416
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Apr 2020 16:06:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment