Change in ...coreboot[master]: superio/nsc: Introduce common early_serial

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31332

Change subject: superio/nsc: Introduce common early_serial
......................................................................

superio/nsc: Introduce common early_serial

Change-Id: I0860e95258b87f059a3a9c31e382d758403d0428
Signed-off-by: Peter Lemenkov 
---
M src/superio/nsc/Makefile.inc
A src/superio/nsc/common/Kconfig
A src/superio/nsc/common/early_serial.c
A src/superio/nsc/common/nsc.h
4 files changed, 80 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/31332/1

diff --git a/src/superio/nsc/Makefile.inc b/src/superio/nsc/Makefile.inc
index a792573..8323591 100644
--- a/src/superio/nsc/Makefile.inc
+++ b/src/superio/nsc/Makefile.inc
@@ -13,6 +13,10 @@
 ## GNU General Public License for more details.
 ##

+## include generic nsc pre-ram stage driver
+bootblock-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c
+romstage-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c
+
 subdirs-y += pc87309
 subdirs-y += pc87360
 subdirs-y += pc87366
diff --git a/src/superio/nsc/common/Kconfig b/src/superio/nsc/common/Kconfig
new file mode 100644
index 0000000..e486071
--- /dev/null
+++ b/src/superio/nsc/common/Kconfig
@@ -0,0 +1,19 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2011 Advanced Micro Devices, Inc.
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+
+# Generic NSC romstage driver - Just enough UART initialisation code for
+# pre-ram.
+config SUPERIO_NSC_COMMON_PRE_RAM
+	bool
diff --git a/src/superio/nsc/common/early_serial.c b/src/superio/nsc/common/early_serial.c
new file mode 100644
index 0000000..2cd9f05
--- /dev/null
+++ b/src/superio/nsc/common/early_serial.c
@@ -0,0 +1,31 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2000 AG Electronics Ltd.
+ * Copyright (C) 2003-2004 Linux Networx
+ * Copyright (C) 2004 Tyan
+ * Copyright (C) 2007 Uwe Hermann 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/io.h>
+#include <device/pnp_def.h>
+#include <stdint.h>
+#include "nsc.h"
+
+void nsc_enable_serial(pnp_devfn_t dev, u16 iobase)
+{
+	pnp_set_logical_device(dev);
+	pnp_set_enable(dev, 0);
+	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
+	pnp_set_enable(dev, 1);
+}
diff --git a/src/superio/nsc/common/nsc.h b/src/superio/nsc/common/nsc.h
new file mode 100644
index 0000000..76112dc
--- /dev/null
+++ b/src/superio/nsc/common/nsc.h
@@ -0,0 +1,26 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2014 Edward O'Callaghan 
+ * Copyright (C) 2014 Felix Held 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef SUPERIO_NSC_COMMON_PRE_RAM_H
+#define SUPERIO_NSC_COMMON_PRE_RAM_H
+
+#include <device/pnp_def.h>
+#include <stdint.h>
+
+void nsc_enable_serial(pnp_devfn_t dev, u16 iobase);
+
+#endif /* SUPERIO_NSC_COMMON_PRE_RAM_H */

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31332 )

Change subject: superio/nsc: Introduce common early_serial
......................................................................

Patch Set 1: Code-Review+1

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31332 )

Change subject: superio/nsc: Introduce common early_serial
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/31332/1/src/superio/nsc/common/Kconfig 
File src/superio/nsc/common/Kconfig:

https://review.coreboot.org/#/c/31332/1/src/superio/nsc/common/Kconfig@1 
PS1, Line 1: ##
           : ## This file is part of the coreboot project.
           : ##
           : ## Copyright (C) 2011 Advanced Micro Devices, Inc.
           : ##
           : ## This program is free software; you can redistribute it and/or modify
           : ## it under the terms of the GNU General Public License as published by
           : ## the Free Software Foundation; version 2 of the License.
           : ##
           : ## This program is distributed in the hope that it will be useful,
           : ## but WITHOUT ANY WARRANTY; without even the implied warranty of
           : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
           : ## GNU General Public License for more details.
           : ##
I wouldn't include this header in a file that only adds a Kconfig option, but it doesn't hurt to keep it.

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31332 )

Change subject: superio/nsc: Introduce common early_serial
......................................................................

superio/nsc: Introduce common early_serial

Change-Id: I0860e95258b87f059a3a9c31e382d758403d0428
Signed-off-by: Peter Lemenkov 
Reviewed-on: https://review.coreboot.org/c/31332
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Felix Held 
---
M src/superio/nsc/Makefile.inc
A src/superio/nsc/common/Kconfig
A src/superio/nsc/common/early_serial.c
A src/superio/nsc/common/nsc.h
4 files changed, 80 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Felix Held: Looks good to me, approved

diff --git a/src/superio/nsc/Makefile.inc b/src/superio/nsc/Makefile.inc
index a792573..8323591 100644
--- a/src/superio/nsc/Makefile.inc
+++ b/src/superio/nsc/Makefile.inc
@@ -13,6 +13,10 @@
 ## GNU General Public License for more details.
 ##

+## include generic nsc pre-ram stage driver
+bootblock-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c
+romstage-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c
+
 subdirs-y += pc87309
 subdirs-y += pc87360
 subdirs-y += pc87366
diff --git a/src/superio/nsc/common/Kconfig b/src/superio/nsc/common/Kconfig
new file mode 100644
index 0000000..e486071
--- /dev/null
+++ b/src/superio/nsc/common/Kconfig
@@ -0,0 +1,19 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2011 Advanced Micro Devices, Inc.
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+
+# Generic NSC romstage driver - Just enough UART initialisation code for
+# pre-ram.
+config SUPERIO_NSC_COMMON_PRE_RAM
+	bool
diff --git a/src/superio/nsc/common/early_serial.c b/src/superio/nsc/common/early_serial.c
new file mode 100644
index 0000000..2cd9f05
--- /dev/null
+++ b/src/superio/nsc/common/early_serial.c
@@ -0,0 +1,31 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2000 AG Electronics Ltd.
+ * Copyright (C) 2003-2004 Linux Networx
+ * Copyright (C) 2004 Tyan
+ * Copyright (C) 2007 Uwe Hermann 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/io.h>
+#include <device/pnp_def.h>
+#include <stdint.h>
+#include "nsc.h"
+
+void nsc_enable_serial(pnp_devfn_t dev, u16 iobase)
+{
+	pnp_set_logical_device(dev);
+	pnp_set_enable(dev, 0);
+	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
+	pnp_set_enable(dev, 1);
+}
diff --git a/src/superio/nsc/common/nsc.h b/src/superio/nsc/common/nsc.h
new file mode 100644
index 0000000..76112dc
--- /dev/null
+++ b/src/superio/nsc/common/nsc.h
@@ -0,0 +1,26 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2014 Edward O'Callaghan 
+ * Copyright (C) 2014 Felix Held 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef SUPERIO_NSC_COMMON_PRE_RAM_H
+#define SUPERIO_NSC_COMMON_PRE_RAM_H
+
+#include <device/pnp_def.h>
+#include <stdint.h>
+
+void nsc_enable_serial(pnp_devfn_t dev, u16 iobase);
+
+#endif /* SUPERIO_NSC_COMMON_PRE_RAM_H */