Attention is currently required from: Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Add strict flag to clock_configure() ......................................................................
Patch Set 4:
(1 comment)
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/f31d2f4c_8db6560d PS4, Line 311: false
Why can't these be checked?
I think that I definitely wanted to check for the SPI frequency but didn't want to screw up the other checks in case they were expecting it to round up to the higher frequency if there wasn't an exact match. I actually wasn't sure what the other clocks were but was mainly focusing on the qspi clock frequency, which is why i defaulted everything else to false. Anyway, I can try enabling and making sure everything boots still at least.
-
Shelley Chen (Code Review)