Change in ...coreboot[master]: libpayload: Add UART for qcs405 - coreboot-gerrit

11 Jun 2019


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29957 )
Change subject: libpayload: Add UART for qcs405
......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... 
File payloads/libpayload/drivers/serial/qcs405.c:
https://review.coreboot.org/#/c/29957/20/payloads/libpayload/drivers/serial/... 
PS20, Line 544: /* For simplicity sake let's rely on coreboot initalizing the UART. */
...
We have identified that uart rx command registers are getting reset at the end of coreboot stage due […]
It's fine to only do the initialization that's needed at this point.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43164cf9eacc844af1d048f7b6ebbda96fc9d202
Gerrit-Change-Number: 29957
Gerrit-PatchSet: 26
Gerrit-Owner: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Mukesh Savaliya msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Prudhvi Yarlagadda pyarlaga@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Jun 2019 21:58:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Prudhvi Yarlagadda pyarlaga@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment