Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52588 )
Change subject: soc/intel/common: Add virtual wire mapping entries to GPIO communities ......................................................................
Patch Set 4:
(4 comments)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/52588/comment/3405b21f_7156601d PS4, Line 784: comm->vw_entries[i].first_pad Shouldn't this be `pad - comm->vw_entries[i].first_pad`?
File src/soc/intel/common/block/include/intelblocks/gpio.h:
https://review.coreboot.org/c/coreboot/+/52588/comment/1263e327_5a2c10c8 PS4, Line 133: vw_entries Should we add a comment here that the entries are supposed to be in the order in which the groups map to the VW indexes starting with the vw_base?
https://review.coreboot.org/c/coreboot/+/52588/comment/5968271a_4741179a PS4, Line 133: nit: use tab like other members?
https://review.coreboot.org/c/coreboot/+/52588/comment/0289b621_96877c00 PS4, Line 252: it will return 1, and vw_index and vw_bit will be set to -1 Needs update.