Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
4 comments:
File src/soc/intel/common/block/gpio/gpio.c:
Patch Set #4, Line 784: comm->vw_entries[i].first_pad
Shouldn't this be `pad - comm->vw_entries[i].first_pad`?
File src/soc/intel/common/block/include/intelblocks/gpio.h:
Patch Set #4, Line 133: vw_entries
Should we add a comment here that the entries are supposed to be in the order in which the groups map to the VW indexes starting with the vw_base?
nit: use tab like other members?
Patch Set #4, Line 252: it will return 1, and vw_index and vw_bit will be set to -1
Needs update.
To view, visit change 52588. To unsubscribe, or for help writing mail filters, visit settings.