Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25817 )
Change subject: libpayload: Add UART for sdm845 ......................................................................
Patch Set 53:
(1 comment)
https://review.coreboot.org/#/c/25817/53/payloads/libpayload/drivers/serial/... File payloads/libpayload/drivers/serial/sdm845.c:
https://review.coreboot.org/#/c/25817/53/payloads/libpayload/drivers/serial/... PS53, Line 267: { BTW, I think you asked a while ago why you still see depthcharge UART output even when building a production image, T.mike. The reason is that this should have a check for (lib_sysinfo.serial == NULL) and not register the console driver in that case, like all the other serial drivers here. (I'm not gonna review this driver further until there is some movement on CB:25373, since there is a lot of overlap.)
-
Julius Werner (Code Review)