Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Sudheer Amrabadi.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot
......................................................................
Patch Set 9:
(1 comment)
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/2a25704b_a3f03c92
PS4, Line 12: static struct chipinfo chipinfolut[] = {
Done
So which one is it, future purpose or readability?
If you just want readability, you can put the other ID in comments, no need to bloat the binary image with it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 9
Gerrit-Owner: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Tue, 01 Nov 2022 22:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taniya Das
tdas@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment