Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55051 )
Change subject: soc/mediatek: Initialize SSPM
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55051/comment/c653e31a_fb788f58
PS2, Line 11: TEST=none
Please do, and add how much time it adds to the boot.
File src/soc/mediatek/mt8195/Kconfig:
https://review.coreboot.org/c/coreboot/+/55051/comment/30567857_b8fb0a26
PS2, Line 32: The file name of the MediaTek SSPM firmware.
Maybe add in what path the file is expected in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia227ea9f7d58129068cb36ec2de7d9feb677006b
Gerrit-Change-Number: 55051
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sat, 29 May 2021 07:23:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment