Attention is currently required from: Subrata Banik, Kapil Porwal, Lean Sheng Tan, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71275 )
Change subject: soc/intel/common/block/fast_spi: Hook up pci_dev_ops_pci to set SSID
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/71275/comment/c049aac9_7cda97ee
PS1, Line 545: .ops_pci = &pci_dev_ops_pci,
Yes but here we are using a different variable than `default_pci_ops_dev` i.e. […]
Thank you for the explanation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c7a5a3fdc7389b315e85180c16d1ec335fbba2
Gerrit-Change-Number: 71275
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 17:05:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment