Attention is currently required from: Martin L Roth, Jason Nien, Isaac Lee, Jon Murphy, Martin Roth, Eric Peers, Moises Garcia, Tim Van Patten, Karthikeyan Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67209 )
Change subject: mb/google/skyrim/var/winterhold: Add gpio override settings
......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/skyrim/variants/winterhold/gpio.c:
https://review.coreboot.org/c/coreboot/+/67209/comment/4a5dec72_1fa2817e
PS5, Line 7: ramstage*/
nit: add a space before '*/'
Done
https://review.coreboot.org/c/coreboot/+/67209/comment/368dec2e_3a18cd78
PS5, Line 16:
Nit: remove extra space. […]
Done
https://review.coreboot.org/c/coreboot/+/67209/comment/a3d3641f_7055950a
PS5, Line 19: // NC
Remove, or move inside the other comment and add to all of the other comments>
Done
https://review.coreboot.org/c/coreboot/+/67209/comment/e78ffade_d1465d37
PS5, Line 22: /* CLK_REQ1_L / EMMC */
remove?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2086c326cbf46ba6378d18d37dcbbe9fafa6b2bc
Gerrit-Change-Number: 67209
Gerrit-PatchSet: 6
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Moises Garcia
moisesgarcia@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Moises Garcia
moisesgarcia@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Mon, 05 Sep 2022 02:08:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment