[M] Change in coreboot[master]: soc/amd/common/block/data_fabric: Use register bitslice structs

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69073 )

Change subject: soc/amd/common/block/data_fabric: Use register bitslice structs
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File src/soc/amd/common/block/data_fabric/data_fabric_helper.c:

https://review.coreboot.org/c/coreboot/+/69073/comment/0e100555_3e5714e7 
PS1, Line 17: 	ficaa.reg_num = reg >> 2;
not sure if this is obvious from the code, but maybe add a comment here that this is the number of the 32bit register?

https://review.coreboot.org/c/coreboot/+/69073/comment/9b7bea72_d32170b2 
PS1, Line 119: ctrl.raw = data_fabric_broadcast_read32(0, NB_MMIO_CONTROL(i));
             : 		if (!(ctrl.we || ctrl.re))
hm, this is basically is_mmio_reg_disabled, but since we need ctrl.raw in line 147, using that here would result in an additional pci config space access. i'dleave it as it is for now, but maybe look into this in a future patch