Change in coreboot[master]: mb/google/dedede/var/metaknight: Add audio related settings

[Tim Chen (Code Review)]

Hello Tim Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/47438

to review the following change.

Change subject: mb/google/dedede/var/metaknight: Add audio related settings
......................................................................

mb/google/dedede/var/metaknight: Add audio related settings

Add HDA,speaker codec and speaker amp settings.

BUG=b:169813211
BRANCH=None
TEST=build metaknight firmware

Change-Id: I9b1057eac94b568914f17fcccee58a0e403ccec0
Signed-off-by: Tim Chen 
---
M src/mainboard/google/dedede/variants/metaknight/overridetree.cb
1 file changed, 26 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/47438/1

diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
index 25bc866..73ef0b8 100644
--- a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
@@ -80,5 +80,31 @@
    		end
    	end # I2C 2
    	device pci 15.3 off  end # I2C 3
+		device pci 19.0 on
+			chip drivers/i2c/generic
+				register "hid" = ""10EC5682""
+				register "name" = ""RT58""
+				register "desc" = ""Realtek RT5682""
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)"
+				register "property_count" = "1"
+				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
+				register "property_list[0].name" = ""realtek,jd-src""
+				register "property_list[0].integer" = "1"
+				device i2c 1a on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1015""
+				register "desc" = ""Realtek SPK AMP L""
+				register "uid" = "0"
+				device i2c 28 on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1015""
+				register "desc" = ""Realtek SPK AMP R""
+				register "uid" = "1"
+				device i2c 29 on end
+			end
+		end
+		device pci 1f.3 on end # Intel HDA
    end
 end

[Raymond Wong (Code Review)]

Raymond Wong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47438 )

Change subject: mb/google/dedede/var/metaknight: Add audio related settings
......................................................................

Patch Set 2: Code-Review+1

[Tim Chen (Code Review)]

Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47438 )

Change subject: mb/google/dedede/var/metaknight: Add audio related settings
......................................................................

Patch Set 2:

If there is no other concerns, could help to CR+2 for this CL?

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47438 )

Change subject: mb/google/dedede/var/metaknight: Add audio related settings
......................................................................

Patch Set 2: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47438 )

Change subject: mb/google/dedede/var/metaknight: Add audio related settings
......................................................................

mb/google/dedede/var/metaknight: Add audio related settings

Add HDA,speaker codec and speaker amp settings.

BUG=b:169813211
BRANCH=None
TEST=build metaknight firmware

Change-Id: I9b1057eac94b568914f17fcccee58a0e403ccec0
Signed-off-by: Tim Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47438
Tested-by: build bot (Jenkins) 
Reviewed-by: Raymond Wong 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/dedede/variants/metaknight/overridetree.cb
1 file changed, 26 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved
  Raymond Wong: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
index d455a47..000182ec 100644
--- a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
@@ -100,5 +100,31 @@
    		end
    	end # I2C 2
    	device pci 15.3 off  end # I2C 3
+		device pci 19.0 on
+			chip drivers/i2c/generic
+				register "hid" = ""10EC5682""
+				register "name" = ""RT58""
+				register "desc" = ""Realtek RT5682""
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)"
+				register "property_count" = "1"
+				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
+				register "property_list[0].name" = ""realtek,jd-src""
+				register "property_list[0].integer" = "1"
+				device i2c 1a on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1015""
+				register "desc" = ""Realtek SPK AMP L""
+				register "uid" = "0"
+				device i2c 28 on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1015""
+				register "desc" = ""Realtek SPK AMP R""
+				register "uid" = "1"
+				device i2c 29 on end
+			end
+		end
+		device pci 1f.3 on end # Intel HDA
    end
 end