Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/24908 )
Change subject: security/tpm: Implement hashing function in TSS ......................................................................
Patch Set 5:
(4 comments)
I forgot to publish my comments.
https://review.coreboot.org/#/c/24908/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/24908/1//COMMIT_MSG@11 PS1, Line 11: * TPM 1.2 and 2.0 support. Add support for TPM 1.2 and 2.0
https://review.coreboot.org/#/c/24908/1/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/#/c/24908/1/src/security/tpm/tss.h@162 PS1, Line 162: can hashed can be hashed
https://review.coreboot.org/#/c/24908/1/src/security/tpm/tss.h@172 PS1, Line 172: lastest latest
https://review.coreboot.org/#/c/24908/1/src/security/tpm/tss/tcg-1.2/tss_com... File src/security/tpm/tss/tcg-1.2/tss_commands.h:
https://review.coreboot.org/#/c/24908/1/src/security/tpm/tss/tcg-1.2/tss_com... PS1, Line 176: const struct s_tpm_sha1_start_cmd{ Add a space before the {?
-
Paul Menzel (Code Review)