Change in coreboot[master]: mb/clevo/l140cu: Remove duplicate Kconfig type definitions

List overview All Threads
Download

newer

older

[M] Change in coreboot[master]:...

Change in coreboot[master]:...

Felix Singer (Code Review)

23 Sep 2020 23 Sep '20

2:19 a.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45637 )

Change subject: mb/clevo/l140cu: Remove duplicate Kconfig type definitions ......................................................................

mb/clevo/l140cu: Remove duplicate Kconfig type definitions

Remove type definitions from Kconfig since these are already defined elsewhere.

Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/l140cu/Kconfig 1 file changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/45637/1

diff --git a/src/mainboard/clevo/l140cu/Kconfig b/src/mainboard/clevo/l140cu/Kconfig index 84d6530..5185087 100644 --- a/src/mainboard/clevo/l140cu/Kconfig +++ b/src/mainboard/clevo/l140cu/Kconfig @@ -22,59 +22,45 @@ select USE_LEGACY_8254_TIMER # Fix failure to boot GRUB

config MAINBOARD_DIR - string default "clevo/l140cu"

config MAINBOARD_PART_NUMBER - string default "L140CU"

config MAINBOARD_SMBIOS_PRODUCT_NAME - string default "L140CU"

config MAINBOARD_VERSION - string default "2.1A"

config CBFS_SIZE - hex default 0xc00000

config CONSOLE_POST - bool default y

config UART_FOR_CONSOLE - int default 2

config MAX_CPUS - int default 8

config DIMM_MAX - int default 2

config DIMM_SPD_SIZE - int default 512

config VGA_BIOS_FILE - string default "pci8086,9b41.rom"

config VGA_BIOS_ID - string default "8086,9b41"

config TPM_PIRQ - hex default 0x10 # GPP_A7/PIRQA#

config POST_DEVICE - bool default n

endif

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Michael Niewöhner (Code Review)

23 Sep 23 Sep

7:18 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45637 )

Change subject: mb/clevo/l140cu: Remove duplicate Kconfig type definitions ......................................................................

Patch Set 2: Code-Review+1

not sure if it's better to keep them (like done in many boards)

-- To view, visit https://review.coreboot.org/c/coreboot/+/45637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Gerrit-Change-Number: 45637 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Sep 2020 17:18:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

13 Oct 13 Oct

5:22 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45637 )

Change subject: mb/clevo/l140cu: Remove duplicate Kconfig type definitions ......................................................................

Patch Set 2: Code-Review+2

I changed my opinion. Let's drop these duplicates

-- To view, visit https://review.coreboot.org/c/coreboot/+/45637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Gerrit-Change-Number: 45637 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 13 Oct 2020 15:22:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

9:22 p.m.

New subject: Change in coreboot[master]: mb/clevo/cml-u: Remove duplicate Kconfig type definitions

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45637

to look at the new patch set (#3).

Change subject: mb/clevo/cml-u: Remove duplicate Kconfig type definitions ......................................................................

mb/clevo/cml-u: Remove duplicate Kconfig type definitions

Remove type definitions from Kconfig since these are already defined elsewhere.

Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/Kconfig 1 file changed, 0 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/45637/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/45637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Gerrit-Change-Number: 45637 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

10:34 p.m.

New subject: Change in coreboot[master]: mb/clevo/cml-u: Remove duplicate Kconfig type definitions

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45637 )

Change subject: mb/clevo/cml-u: Remove duplicate Kconfig type definitions ......................................................................

Patch Set 3:

That's a lot of options. If any of them isn't declared with the type globally, you rely on the type set by another board (I guess, but who really knows). Please check if they all have a declaration already.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Gerrit-Change-Number: 45637 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 13 Oct 2020 20:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

11:17 p.m.

New subject: Change in coreboot[master]: mb/clevo/cml-u: Remove duplicate Kconfig type definitions

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45637 )

Change subject: mb/clevo/cml-u: Remove duplicate Kconfig type definitions ......................................................................

Patch Set 3:

(16 comments)

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... File src/mainboard/clevo/cml-u/Kconfig:

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 23: config MAINBOARD_DIR not yet declared globally; let's add it to src/mainboard/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 26: config MAINBOARD_PART_NUMBER : default "L140CU" if BOARD_CLEVO_L140CU : not yet declared globally; let's add it to src/Kconfig, where the other MAINBOARD_* options are located

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 29: config MAINBOARD_VERSION declared in src/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 32: config DEVICETREE declared in src/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 35: config CBFS_SIZE declared in src/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 38: config CONSOLE_POST declared in src/console/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 41: config UART_FOR_CONSOLE declared in src/console/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 44: MAX_CPUS declared in src/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 47: config DIMM_MAX declared in src/lib/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 50: config DIMM_SPD_SIZE declared in src/lib/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 53: config VGA_BIOS_FILE declared in src/device/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 56: config VGA_BIOS_ID declared in src/device/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 59: config TPM_PIRQ declared in src/drivers/pc80/tpm/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 62: config POST_DEVICE declared in src/console/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 65: config VARIANT_DIR not yet declared globally; let's add it to src/mainboard/Kconfig

https://review.coreboot.org/c/coreboot/+/45637/3/src/mainboard/clevo/cml-u/K... PS3, Line 69: config SEABIOS_PS2_TIMEOUT declared in payloads/external/SeaBIOS/Kconfig

-- To view, visit https://review.coreboot.org/c/coreboot/+/45637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Gerrit-Change-Number: 45637 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 13 Oct 2020 21:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

10 Jun 10 Jun

5:07 a.m.

New subject: [S] Change in coreboot[master]: mb/clevo/cml-u: Remove duplicate Kconfig type definitions

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45637?usp=email )

Change subject: mb/clevo/cml-u: Remove duplicate Kconfig type definitions ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/45637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97 Gerrit-Change-Number: 45637 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer service+coreboot-gerrit@felixsinger.de Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: abandon

532

days inactive

1522

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Felix Singer (Code Review)
Michael Niewöhner (Code Review)
Nico Huber (Code Review)
Stefan Reinauer (Code Review)