Attention is currently required from: Hung-Te Lin, Paul Menzel, Rex-BC Chen, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot tables: Add PCIe info to coreboot table ......................................................................
Patch Set 6:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63251/comment/a495c87b_5aeb02d4 PS6, Line 9: function functions
https://review.coreboot.org/c/coreboot/+/63251/comment/cbb65010_b42262a4 PS6, Line 10: through from
https://review.coreboot.org/c/coreboot/+/63251/comment/ff301eab_60d7a2b3 PS6, Line 13: , add new API . Therefore, new API is added
https://review.coreboot.org/c/coreboot/+/63251/comment/115f049d_0da4eb4c PS6, Line 15: libpayload payloads
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/916d8991_1318535a PS6, Line 278: uint32_t config_size; Move config_size below config_base.
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/185e230d_61e79604 PS4, Line 87: struct {
Done, I use memcpy to fill the structure, I'm not sure which one is better, any suggestions?
Both methods should be fine.
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/8c74d129_14c0c678 PS6, Line 176: uint32_t config_size; Same.
-
Yu-Ping Wu (Code Review)