Change in coreboot[master]: amdfwtool: Add a function to extract firmwares

[Bao Zheng (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54901 )

Change subject: amdfwtool: Add a function to extract firmwares
......................................................................

Patch Set 8:

(5 comments)

File util/amdfwtool/extract.c:

https://review.coreboot.org/c/coreboot/+/54901/comment/8f193c8c_3544c58f 
PS6, Line 75: if (token == 6 || token == 0xb)
> Use the amd_fw_type enums?  BTW what is 6?

Done

https://review.coreboot.org/c/coreboot/+/54901/comment/e8423e6c_438ac5ad 
PS6, Line 110: extract_bios_fws
> All comments in extract_psp_fws() apply here too

Done

https://review.coreboot.org/c/coreboot/+/54901/comment/b0d905d3_f8d05a9b 
PS6, Line 178: romsig_offset
> This has a strange look here after the init of romsig_offsets.  I'd put it on the next line.

Done

https://review.coreboot.org/c/coreboot/+/54901/comment/af859ab1_1e67c973 
PS6, Line 238: 	ppsp = (psp_directory_table *)&buffer[psp2_offset];
             : 	extract_psp_fws(buffer, ppsp, image_base, NULL);
> Probably surround these with […]

Done.

Pass in/out the pointer instead.

https://review.coreboot.org/c/coreboot/+/54901/comment/20cef9e4_34db2b07 
PS6, Line 242: 	pbdt = (bios_directory_table *)&buffer[bhd2_offset];
             : 	extract_bios_fws(buffer, pbdt, image_base, NULL);
> same as above

Done