Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18952 )
Change subject: soc/intel/common/block: Add Intel common UART code ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/18952/4/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/uart.h:
PS4, Line 19: #include <arch/io.h> why we need this here?
https://review.coreboot.org/#/c/18952/4/src/soc/intel/common/block/uart/uart... File src/soc/intel/common/block/uart/uart.c:
Line 18: #include <soc/uart.h> u need io.h here
PS4, Line 36: clk_sel = UART_CLK_DIV_N(UART_CLK_N_VAL) | UART_CLK_DIV_M(UART_CLK_M_VAL);
80