Attention is currently required from: Angel Pons, Benjamin Doron, Christian Walter, Leon Groß, Nico Huber, Patrick Rudolph.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email )
Change subject: mb/emulation: Add SIMICS QSP support ......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS4:
I'm not sure if I follow. You expect current users of Simics to adopt this? Currently, with QEMU it's as simple as running `make qemu`. Are there plans to make Simics as easy to use? if not, wouldn't it be better to teach people about QEMU?
I guess we can start from here :)
i mean it is no harm to add more support to the platform for coreboot i guess?
Every addition also adds at least some maintenance overhead. I've often seen redundant additions to be abandoned and bit rot.
This sounds pretty discouraging to be honest. If every time someone spend some time to implement a nice additional feature or implement new board support (in this case it actually takes 2 months for the engineer to work on this), and we shoot it down with the reason "oh please dont do it it just add more maintainance", that is not very welcoming to the new coreboot leaner who try to work on something isn't it? 😊 And also we have maintainer list for this purpose - so I personally dont see it is a big issue here.
It is a nice addition as well. As it does have specific use cases (although quite limited): as Intel or silicon vendors usually use Simics for the RTL simulation before the actual silicon is available, actively used by the internal engineers for that.
Do they use QSP?
I guess so, as you can see Intel engineers actively update it in edk2 tree. So my work is that i am also in discussion with the Simics guy to also include coreboot binary as default binary (together with current UEFI edk2 binary), and that could also help to promote coreboot to more people 😊
EDK2 and Slimbootloader already have nice support for Simics: https://slimbootloader.github.io/supported-hardware/qsp.html https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/Simic...
And others have support for other open-source emulators, e.g. Bochs. Still we don't add those, why?
Sure, we should welcome everyone who wants to contribute it, as long as there is volunteer who wants to port coreboot for other emulators, e.g. Bochs.
-
Lean Sheng Tan (Code Review)