Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.... File src/mainboard/lenovo/t430s/hda_verb.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.... PS8, Line 16:
"unable to make 'build/ramstage/mainboard/lenovo/t430s/hda_verb. […]
Removing it will cause "unable to make 'build/ramstage/mainboard/lenovo/t430s/hda_verb.o'" will be complained when invoking make.
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t431s/smihandler.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 25:
the whole file should be removed. […]
Ack
-
Bill XIE (Code Review)