Attention is currently required from: Ashish Kumar Mishra, Ashish Kumar Mishra, Subrata Banik.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80780?usp=email )
Change subject: mb/google/brox: Enable Wake on WLAN for SKU1
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80780/comment/b4371ae4_7111050a :
PS1, Line 273: chip drivers/wifi/generic
: register "wake" = "GPE0_DW0_03"
: register "add_acpi_dma_property" = "true"
: device pci 00.0 on
: probe WIFI_BT WIFI_BT_PCIE
: end
: end
There's no wake knob in rtd3. Hence added this.
Just to clarify, this means that we need to load two drivers in the kernel for the wifi chip? The generic one to take care of the wake functionality and rtd3 one to take care of resetting the device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80780?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04c35da2c9ac57cafdf7f7a35d83ab2e7a05fe4a
Gerrit-Change-Number: 80780
Gerrit-PatchSet: 1
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.corp-partner.google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 04 Mar 2024 18:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Ashish Kumar Mishra
ashish.k.mishra@intel.corp-partner.google.com
Gerrit-MessageType: comment