Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52908 )
Change subject: mb/google/guybrush: Configure wake resource for WiFi
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52908/comment/9136031f_541f1ed7
PS1, Line 13: is added to SSDT.
I checked the GPE_EN bit and observed that GEVENT_8 is not set/enabled
At what point did you check it? IIUC, it gets set on the suspend path in kernel.
Later when the system resumes due to other wake sources, I can see that the bit corresponding to GEVENT_8 status is not set.
Did you probe the WAKE# line in hardware? Does that toggle at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic238d9606aea20c058e9b47093693f10b14e6288
Gerrit-Change-Number: 52908
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 10 May 2021 21:13:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment