[S] Change in coreboot[master]: soc/intel/elkhartlake: Move TCO_NO_REBOOT flag support

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Lean Sheng Tan, Werner Zeh.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70151 )

Change subject: soc/intel/elkhartlake: Move TCO_NO_REBOOT flag support
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> Is this bit really  generic enough across all platforms? I remember back than that it is not, see CB […]

If there is a PCI device not supporting bus-mastering and the related PCI command register bit is hard-wired to 0, you would not suggest creating and using a custom pci_def.h (?) file for that chipset just to remove PCI_COMMAND_MASTER?

Can't the solution be not calling the function that sets such bit?

So far I have not come across separate TCO register specs document from intel to refer to. If some platform leaves a bit reserved or undocumented, does that justify copy-pasting most of TCO support source? Or worse, adjust the names just a bit because preprocessor complaints on conflicts.