Change in coreboot[master]: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Daniel Kang (Code Review)

19 Mar 2020 19 Mar '20

10:42 p.m.

Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI

Camera ACPI had an incorrect board config flag for TGL-UP4.

BUG=None BRANCH=None TEST=Build and boot TGLRVP-UP3 or UP4. Start camera app and able to capture images.

Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Signed-off-by: Daniel Kang daniel.h.kang@intel.com --- M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39682/1

diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl index 9cb8817..f90139d 100644 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -390,7 +390,7 @@ CTXS(GPP_H12)

/* Pull PWREN high */ -#if CONFIG_BOARD_INTEL_TIGERLAKE_RVPY +#if CONFIG_BOARD_INTEL_TGLRVP_UP4 STXS(GPP_E22) #else STXS(GPP_R6) @@ -416,7 +416,7 @@ CTXS(GPP_H12)

/* Pull PWREN low */ -#if CONFIG_BOARD_INTEL_TIGERLAKE_RVPY +#if CONFIG_BOARD_INTEL_TGLRVP_UP4 CTXS(GPP_E22) #else CTXS(GPP_R6)

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Daniel Kang (Code Review)

19 Mar 19 Mar

10:49 p.m.

Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

Patch Set 1: Code-Review+1

Daniel Kang (Code Review)

10:52 p.m.

Hello build bot (Jenkins), Patrick Georgi, Wonkyu Kim,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39682

to look at the new patch set (#2).

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI

Camera ACPI had an incorrect board config flag for TGL-UP4.

BUG=None BRANCH=None TEST=Build and boot TGLRVP-UP3 or UP4. Start camera app and able to capture images.

Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 --- M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39682/2

Wonkyu Kim (Code Review)

10:56 p.m.

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

Patch Set 2: Code-Review+2

Caveh Jalali (Code Review)

10:59 p.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 19 Mar 2020 21:59:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Daniel Kang (Code Review)

20 Mar 20 Mar

11:42 p.m.

Hello Shaunak Saha, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39682

to look at the new patch set (#3).

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI

Camera ACPI had an incorrect board config flag for TGL-UP4.

BUG=None BRANCH=None TEST=Build and boot TGLRVP-UP3 or UP4. Start camera app and able to capture images.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39682/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Daniel Kang (Code Review)

11:46 p.m.

Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 20 Mar 2020 22:46:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Wonkyu Kim (Code Review)

21 Mar 21 Mar

1:08 a.m.

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 21 Mar 2020 00:08:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

23 Mar 23 Mar

10:35 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39682 )

Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................

src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI

Camera ACPI had an incorrect board config flag for TGL-UP4.

BUG=None BRANCH=None TEST=Build and boot TGLRVP-UP3 or UP4. Start camera app and able to capture images.

Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Signed-off-by: Daniel Kang daniel.h.kang@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39682 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl 1 file changed, 5 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified Wonkyu Kim: Looks good to me, approved Daniel Kang: Looks good to me, but someone else must approve

diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl index 9cb8817..de26fd9 100644 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -390,10 +390,10 @@ CTXS(GPP_H12)

/* Pull PWREN high */ -#if CONFIG_BOARD_INTEL_TIGERLAKE_RVPY - STXS(GPP_E22) +#if CONFIG(BOARD_INTEL_TGLRVP_UP4) + STXS(GPP_E22) #else - STXS(GPP_R6) + STXS(GPP_R6) #endif Sleep(2) /* reset pulse width */

@@ -416,8 +416,8 @@ CTXS(GPP_H12)

/* Pull PWREN low */ -#if CONFIG_BOARD_INTEL_TIGERLAKE_RVPY - CTXS(GPP_E22) +#if CONFIG(BOARD_INTEL_TGLRVP_UP4) + CTXS(GPP_E22) #else CTXS(GPP_R6) #endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/39682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1873

days inactive

1877

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Caveh Jalali (Code Review)
Daniel Kang (Code Review)
Patrick Georgi (Code Review)
Wonkyu Kim (Code Review)