Change in coreboot[master]: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files
Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48542 )
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
soc/intel/elkhartlake: Update USB & PCIe devices in ASL files
Update USB & PCIe devices in ASL files as per EHL EDS.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I8b567127fbdd880ccc0a5e0ca334162f9f4f5164 --- M src/soc/intel/elkhartlake/acpi/pcie.asl M src/soc/intel/elkhartlake/acpi/xhci.asl 2 files changed, 9 insertions(+), 92 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/48542/1
diff --git a/src/soc/intel/elkhartlake/acpi/pcie.asl b/src/soc/intel/elkhartlake/acpi/pcie.asl index a19feb7..464f8d6 100644 --- a/src/soc/intel/elkhartlake/acpi/pcie.asl +++ b/src/soc/intel/elkhartlake/acpi/pcie.asl @@ -214,88 +214,3 @@ Return (IRQM (RPPN)) } } - -Device (RP08) -{ - Name (_ADR, 0x001C0007) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP09) -{ - Name (_ADR, 0x001D0000) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP10) -{ - Name (_ADR, 0x001D0001) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP11) -{ - Name (_ADR, 0x001D0002) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP12) -{ - Name (_ADR, 0x001D0003) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} diff --git a/src/soc/intel/elkhartlake/acpi/xhci.asl b/src/soc/intel/elkhartlake/acpi/xhci.asl index 445c7db..eae21da 100644 --- a/src/soc/intel/elkhartlake/acpi/xhci.asl +++ b/src/soc/intel/elkhartlake/acpi/xhci.asl @@ -38,13 +38,15 @@ Device (HS06) { Name (_ADR, 6) } Device (HS07) { Name (_ADR, 7) } Device (HS08) { Name (_ADR, 8) } - + Device (HS09) { Name (_ADR, 9) } + Device (HS10) { Name (_ADR, 10) } + Device (HS11) { Name (_ADR, 11) } + Device (HS12) { Name (_ADR, 12) } + /* USB3 */ - Device (SS01) { Name (_ADR, 9) } - Device (SS02) { Name (_ADR, 10) } - Device (SS03) { Name (_ADR, 11) } - Device (SS04) { Name (_ADR, 12) } - Device (SS05) { Name (_ADR, 13) } - Device (SS06) { Name (_ADR, 14) } + Device (SS01) { Name (_ADR, 13) } + Device (SS02) { Name (_ADR, 14) } + Device (SS03) { Name (_ADR, 15) } + Device (SS04) { Name (_ADR, 16) } } }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48542 )
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48542/1/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/48542/1/src/soc/intel/elkhartlake/a... PS1, Line 45: trailing whitespace
Hello build bot (Jenkins), Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48542
to look at the new patch set (#2).
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
soc/intel/elkhartlake: Update USB & PCIe devices in ASL files
Update USB & PCIe devices in ASL files as per EHL EDS.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I8b567127fbdd880ccc0a5e0ca334162f9f4f5164 --- M src/soc/intel/elkhartlake/acpi/pcie.asl M src/soc/intel/elkhartlake/acpi/xhci.asl 2 files changed, 8 insertions(+), 91 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/48542/2
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48542 )
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48542/1/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/48542/1/src/soc/intel/elkhartlake/a... PS1, Line 45:
trailing whitespace
Done
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48542 )
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48542
to look at the new patch set (#3).
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
soc/intel/elkhartlake: Update USB & PCIe devices in ASL files
Update USB & PCIe devices in ASL files as per EHL EDS.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I8b567127fbdd880ccc0a5e0ca334162f9f4f5164 --- M src/soc/intel/elkhartlake/acpi/pcie.asl M src/soc/intel/elkhartlake/acpi/xhci.asl 2 files changed, 8 insertions(+), 91 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/48542/3
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48542 )
Change subject: soc/intel/elkhartlake: Update USB & PCIe devices in ASL files ......................................................................
soc/intel/elkhartlake: Update USB & PCIe devices in ASL files
Update USB & PCIe devices in ASL files as per EHL EDS.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I8b567127fbdd880ccc0a5e0ca334162f9f4f5164 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48542 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/soc/intel/elkhartlake/acpi/pcie.asl M src/soc/intel/elkhartlake/acpi/xhci.asl 2 files changed, 8 insertions(+), 91 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/soc/intel/elkhartlake/acpi/pcie.asl b/src/soc/intel/elkhartlake/acpi/pcie.asl index a19feb7..464f8d6 100644 --- a/src/soc/intel/elkhartlake/acpi/pcie.asl +++ b/src/soc/intel/elkhartlake/acpi/pcie.asl @@ -214,88 +214,3 @@ Return (IRQM (RPPN)) } } - -Device (RP08) -{ - Name (_ADR, 0x001C0007) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP09) -{ - Name (_ADR, 0x001D0000) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP10) -{ - Name (_ADR, 0x001D0001) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP11) -{ - Name (_ADR, 0x001D0002) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} - -Device (RP12) -{ - Name (_ADR, 0x001D0003) - - OperationRegion (RPCS, PCI_Config, 0x4c, 4) - Field (RPCS, AnyAcc, NoLock, Preserve) - { - , 24, - RPPN, 8, /* Root Port Number */ - } - - Method (_PRT) - { - Return (IRQM (RPPN)) - } -} diff --git a/src/soc/intel/elkhartlake/acpi/xhci.asl b/src/soc/intel/elkhartlake/acpi/xhci.asl index 445c7db..6557722 100644 --- a/src/soc/intel/elkhartlake/acpi/xhci.asl +++ b/src/soc/intel/elkhartlake/acpi/xhci.asl @@ -38,13 +38,15 @@ Device (HS06) { Name (_ADR, 6) } Device (HS07) { Name (_ADR, 7) } Device (HS08) { Name (_ADR, 8) } + Device (HS09) { Name (_ADR, 9) } + Device (HS10) { Name (_ADR, 10) } + Device (HS11) { Name (_ADR, 11) } + Device (HS12) { Name (_ADR, 12) }
/* USB3 */ - Device (SS01) { Name (_ADR, 9) } - Device (SS02) { Name (_ADR, 10) } - Device (SS03) { Name (_ADR, 11) } - Device (SS04) { Name (_ADR, 12) } - Device (SS05) { Name (_ADR, 13) } - Device (SS06) { Name (_ADR, 14) } + Device (SS01) { Name (_ADR, 13) } + Device (SS02) { Name (_ADR, 14) } + Device (SS03) { Name (_ADR, 15) } + Device (SS04) { Name (_ADR, 16) } } }
-
build bot (Jenkins) (Code Review) -
Lean Sheng Tan (Code Review)
-
Werner Zeh (Code Review)