HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
payloads: Remove unneeded whitespaces
Change-Id: I9c9f4bdb3b43d0632ea53895278d5249da805ce3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M payloads/external/tint/Makefile M payloads/libpayload/arch/arm/cpu.S M payloads/libpayload/arch/arm/virtual.c M payloads/libpayload/crypto/sha1.c M payloads/libpayload/curses/PDCurses/dos/wccdos16.mak M payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak M payloads/libpayload/curses/PDCurses/os2/gccos2.mak M payloads/libpayload/curses/PDCurses/os2/iccos2.mak M payloads/libpayload/curses/PDCurses/os2/wccos2.mak M payloads/libpayload/curses/curses.h M payloads/libpayload/curses/form/form.h M payloads/libpayload/curses/form/fty_regex.c M payloads/libpayload/curses/menu/eti.h M payloads/libpayload/curses/menu/m_global.c M payloads/libpayload/drivers/serial/ipq806x.c M payloads/libpayload/drivers/usb/usb.c 16 files changed, 43 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40123/1
diff --git a/payloads/external/tint/Makefile b/payloads/external/tint/Makefile index 253bfea..9473c02 100644 --- a/payloads/external/tint/Makefile +++ b/payloads/external/tint/Makefile @@ -18,9 +18,9 @@ cd tint; \ if [ -e debian ]; then \ rm -rf debian typedefs.h Makefile; \ - touch Makefile; \ - patch -l -p1 < ../libpayload_tint.patch; \ - fi + touch Makefile; \ + patch -l -p1 < ../libpayload_tint.patch; \ + fi
download: test -d tint || { wget $(project_url); \ diff --git a/payloads/libpayload/arch/arm/cpu.S b/payloads/libpayload/arch/arm/cpu.S index 4a1d41d..a5ff12d 100644 --- a/payloads/libpayload/arch/arm/cpu.S +++ b/payloads/libpayload/arch/arm/cpu.S @@ -81,7 +81,7 @@ lsl ip, ip, r2 @ shift by that into way position mov r0, #1 lsl r2, r0, r2 @ r2 now contains the way decr - mov r0, r3 @ get sets/level (no way yet) + mov r0, r3 @ get sets/level (no way yet) orr r3, r3, ip @ merge way into way/set/level bfc r0, #0, #4 @ clear low 4 bits (level) to get numset - 1 sub r2, r2, r0 @ subtract from way decr diff --git a/payloads/libpayload/arch/arm/virtual.c b/payloads/libpayload/arch/arm/virtual.c index 4337e28..90b1cb5 100644 --- a/payloads/libpayload/arch/arm/virtual.c +++ b/payloads/libpayload/arch/arm/virtual.c @@ -55,10 +55,10 @@ 0ULL << 54 | /* PN. 0:Not restricted */ \ 0ULL << 53 | /* PXN. 0:Not restricted */ \ 1 << 10 | /* AF. 1:Accessed. This is to prevent access \ - * fault when accessed for the first time */ \ + * fault when accessed for the first time */ \ 0 << 6 | /* AP[2:1]. 0b00:full access from PL1 */ \ 0 << 5 | /* NS. 0:Output address is in Secure space */ \ - 0 << 1 | /* block/table. 0:block entry */ \ + 0 << 1 | /* block/table. 0:block entry */ \ 1 << 0 /* validity. 1:valid */ \ ) #define ATTR_NC (ATTR_BASE | (MAIR_INDX_NC << 2)) diff --git a/payloads/libpayload/crypto/sha1.c b/payloads/libpayload/crypto/sha1.c index fc4a4f3..3d5096f 100644 --- a/payloads/libpayload/crypto/sha1.c +++ b/payloads/libpayload/crypto/sha1.c @@ -199,7 +199,7 @@ * @param data Pointer to the input data that shall be hashed. * @param len Length of the input data (in bytes). * @param buf Buffer which will hold the resulting hash (must be at - * least 20 bytes in size). + * least 20 bytes in size). * @return Pointer to the output buffer where the hash is stored. */ u8 *sha1(const u8 *data, size_t len, u8 *buf) diff --git a/payloads/libpayload/curses/PDCurses/dos/wccdos16.mak b/payloads/libpayload/curses/PDCurses/dos/wccdos16.mak index a0cbb22..6ba140d 100644 --- a/payloads/libpayload/curses/PDCurses/dos/wccdos16.mak +++ b/payloads/libpayload/curses/PDCurses/dos/wccdos16.mak @@ -24,11 +24,11 @@ CFLAGS = /bt=$(TARGET) /zq /wx /m$(MODEL) /i=$(PDCURSES_SRCDIR)
!ifeq DEBUG Y -CFLAGS += /d2 /DPDCDEBUG -LDFLAGS = D W A op q sys $(TARGET) +CFLAGS += /d2 /DPDCDEBUG +LDFLAGS = D W A op q sys $(TARGET) !else -CFLAGS += /oneatx -LDFLAGS = op q sys $(TARGET) +CFLAGS += /oneatx +LDFLAGS = op q sys $(TARGET) !endif
LIBEXE = wlib /q /n /t diff --git a/payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak b/payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak index e1ba1cd..a6d9412 100644 --- a/payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak +++ b/payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak @@ -21,11 +21,11 @@ CFLAGS = /bt=$(TARGET) /zq /wx /mf /i=$(PDCURSES_SRCDIR)
!ifeq DEBUG Y -CFLAGS += /d2 /DPDCDEBUG -LDFLAGS = D W A op q sys $(TARGET) +CFLAGS += /d2 /DPDCDEBUG +LDFLAGS = D W A op q sys $(TARGET) !else -CFLAGS += /oneatx -LDFLAGS = op q sys $(TARGET) +CFLAGS += /oneatx +LDFLAGS = op q sys $(TARGET) !endif
LIBEXE = wlib /q /n /t diff --git a/payloads/libpayload/curses/PDCurses/os2/gccos2.mak b/payloads/libpayload/curses/PDCurses/os2/gccos2.mak index caf8021..6fe691a 100644 --- a/payloads/libpayload/curses/PDCurses/os2/gccos2.mak +++ b/payloads/libpayload/curses/PDCurses/os2/gccos2.mak @@ -49,7 +49,7 @@ DEFFILE = pdcurses.def
DLLTARGET = pdcurses.dll -DLLFLAGS = -Zdll -Zcrtdll -Zomf +DLLFLAGS = -Zdll -Zcrtdll -Zomf
LINK = gcc EMXBIND = emxbind diff --git a/payloads/libpayload/curses/PDCurses/os2/iccos2.mak b/payloads/libpayload/curses/PDCurses/os2/iccos2.mak index 06a2c1f..4190c1e 100644 --- a/payloads/libpayload/curses/PDCurses/os2/iccos2.mak +++ b/payloads/libpayload/curses/PDCurses/os2/iccos2.mak @@ -21,11 +21,11 @@ CC = icc
!ifdef DEBUG -CFLAGS = /Sm /Ti+ /O- /Q+ /dPDCDEBUG -LDFLAGS = /NOLOGO /NOE /SE:160 /DEBUG /PMTYPE:VIO +CFLAGS = /Sm /Ti+ /O- /Q+ /dPDCDEBUG +LDFLAGS = /NOLOGO /NOE /SE:160 /DEBUG /PMTYPE:VIO !else -CFLAGS = /Sm /Ti- /O+ /Q+ -LDFLAGS = /NOLOGO /NOE /EXEPACK /PACKCODE /PACKDATA /PMTYPE:VIO +CFLAGS = /Sm /Ti- /O+ /Q+ +LDFLAGS = /NOLOGO /NOE /EXEPACK /PACKCODE /PACKDATA /PMTYPE:VIO !endif
CPPFLAGS = -I$(PDCURSES_SRCDIR) diff --git a/payloads/libpayload/curses/PDCurses/os2/wccos2.mak b/payloads/libpayload/curses/PDCurses/os2/wccos2.mak index d5900d3..e7734e9 100644 --- a/payloads/libpayload/curses/PDCurses/os2/wccos2.mak +++ b/payloads/libpayload/curses/PDCurses/os2/wccos2.mak @@ -21,11 +21,11 @@ CFLAGS = /bt=$(TARGET) /wx /s /zq /i=$(PDCURSES_SRCDIR)
!ifeq DEBUG Y -CFLAGS += /d2 /DPDCDEBUG -LDFLAGS = D A op q sys $(TARGET) +CFLAGS += /d2 /DPDCDEBUG +LDFLAGS = D A op q sys $(TARGET) !else -CFLAGS += /oneatx -LDFLAGS = op q sys $(TARGET) +CFLAGS += /oneatx +LDFLAGS = op q sys $(TARGET) !endif
LIBEXE = wlib /q /n /b /c /t diff --git a/payloads/libpayload/curses/curses.h b/payloads/libpayload/curses/curses.h index 9a2d3b2..475be67 100644 --- a/payloads/libpayload/curses/curses.h +++ b/payloads/libpayload/curses/curses.h @@ -911,7 +911,7 @@ * These pseudo functions are always implemented as macros: */
-#define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) +#define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) #define getbegyx(win,y,x) (y = getbegy(win), x = getbegx(win)) #define getmaxyx(win,y,x) (y = getmaxy(win), x = getmaxx(win)) #define getparyx(win,y,x) (y = getpary(win), x = getparx(win)) @@ -952,8 +952,8 @@ #define getparx(win) ((win)?(win)->_parx:ERR) #define getpary(win) ((win)?(win)->_pary:ERR)
-#define wstandout(win) (wattrset(win,A_STANDOUT)) -#define wstandend(win) (wattrset(win,A_NORMAL)) +#define wstandout(win) (wattrset(win,A_STANDOUT)) +#define wstandend(win) (wattrset(win,A_NORMAL))
#define wattron(win,at) wattr_on(win, NCURSES_CAST(attr_t, at), NULL) #define wattroff(win,at) wattr_off(win, NCURSES_CAST(attr_t, at), NULL) @@ -1275,7 +1275,7 @@ #define WACS_PLUS WACS_SSSS
#define WACS_S1 NCURSES_WACS('o') /* scan line 1 */ -#define WACS_S9 NCURSES_WACS('s') /* scan line 9 */ +#define WACS_S9 NCURSES_WACS('s') /* scan line 9 */ #define WACS_DIAMOND NCURSES_WACS('`') /* diamond */ #define WACS_CKBOARD NCURSES_WACS('a') /* checker board */ #define WACS_DEGREE NCURSES_WACS('f') /* degree symbol */ diff --git a/payloads/libpayload/curses/form/form.h b/payloads/libpayload/curses/form/form.h index d7bb85a..219fd5b 100644 --- a/payloads/libpayload/curses/form/form.h +++ b/payloads/libpayload/curses/form/form.h @@ -112,7 +112,7 @@ *********/
typedef struct formnode { - unsigned short status; /* flags */ + unsigned short status; /* flags */ short rows; /* size in rows */ short cols; /* size in cols */ int currow; /* current row in field window */ @@ -150,7 +150,7 @@ struct typenode * right; /* ptr to operand for | */
void* (*makearg)(va_list *); /* make fieldtype arg */ - void* (*copyarg)(const void *); /* copy fieldtype arg */ + void* (*copyarg)(const void *); /* copy fieldtype arg */ void (*freearg)(void *); /* free fieldtype arg */
#if NCURSES_INTEROP_FUNCS @@ -317,7 +317,7 @@ void (* const free_arg)(void *)); extern NCURSES_EXPORT(int) set_fieldtype_choice (FIELDTYPE *, bool (* const next_choice)(FIELD *,const void *), - bool (* const prev_choice)(FIELD *,const void *)); + bool (* const prev_choice)(FIELD *,const void *));
/******************* * FIELD routines * diff --git a/payloads/libpayload/curses/form/fty_regex.c b/payloads/libpayload/curses/form/fty_regex.c index 2c0a4ca..071cdc2 100644 --- a/payloads/libpayload/curses/form/fty_regex.c +++ b/payloads/libpayload/curses/form/fty_regex.c @@ -64,7 +64,7 @@ return 0; }
-#define INIT register char *sp = RegEx_Init(instring); +#define INIT register char *sp = RegEx_Init(instring); #define GETC() (*sp++) #define PEEKC() (*sp) #define UNGETC(c) (--sp) diff --git a/payloads/libpayload/curses/menu/eti.h b/payloads/libpayload/curses/menu/eti.h index baa6190..152ada7 100644 --- a/payloads/libpayload/curses/menu/eti.h +++ b/payloads/libpayload/curses/menu/eti.h @@ -36,19 +36,19 @@ #define NCURSES_ETI_H_incl 1
#define E_OK (0) -#define E_SYSTEM_ERROR (-1) -#define E_BAD_ARGUMENT (-2) -#define E_POSTED (-3) -#define E_CONNECTED (-4) -#define E_BAD_STATE (-5) -#define E_NO_ROOM (-6) +#define E_SYSTEM_ERROR (-1) +#define E_BAD_ARGUMENT (-2) +#define E_POSTED (-3) +#define E_CONNECTED (-4) +#define E_BAD_STATE (-5) +#define E_NO_ROOM (-6) #define E_NOT_POSTED (-7) #define E_UNKNOWN_COMMAND (-8) #define E_NO_MATCH (-9) #define E_NOT_SELECTABLE (-10) -#define E_NOT_CONNECTED (-11) +#define E_NOT_CONNECTED (-11) #define E_REQUEST_DENIED (-12) -#define E_INVALID_FIELD (-13) +#define E_INVALID_FIELD (-13) #define E_CURRENT (-14)
#endif diff --git a/payloads/libpayload/curses/menu/m_global.c b/payloads/libpayload/curses/menu/m_global.c index 4509996..f207cb6 100644 --- a/payloads/libpayload/curses/menu/m_global.c +++ b/payloads/libpayload/curses/menu/m_global.c @@ -69,7 +69,7 @@ (chtype)A_REVERSE, /* Attribute for selection */ (chtype)A_NORMAL, /* Attribute for nonselection */ (chtype)A_UNDERLINE, /* Attribute for inactive */ - ' ', /* Pad character */ + ' ', /* Pad character */ (Menu_Hook)0, /* Menu init */ (Menu_Hook)0, /* Menu term */ (Menu_Hook)0, /* Item init */ diff --git a/payloads/libpayload/drivers/serial/ipq806x.c b/payloads/libpayload/drivers/serial/ipq806x.c index ef4ce80..333d8a6 100644 --- a/payloads/libpayload/drivers/serial/ipq806x.c +++ b/payloads/libpayload/drivers/serial/ipq806x.c @@ -34,7 +34,7 @@ #define IPQ_UART_DM_IMR(base) (((u8 *)(base)) + 0x14) #define IPQ_UART_DM_IPR(base) (((u8 *)(base)) + 0x18) #define IPQ_UART_DM_IRDA(base) (((u8 *)(base)) + 0x38) -#define IPQ_UART_DM_MISR(base) (((u8 *)(base)) + 0x10) +#define IPQ_UART_DM_MISR(base) (((u8 *)(base)) + 0x10) #define IPQ_UART_DM_MR1(base) (((u8 *)(base)) + 0x00) #define IPQ_UART_DM_MR2(base) (((u8 *)(base)) + 0x04) #define IPQ_UART_DM_NO_CHARS_FOR_TX(base) (((u8 *)(base)) + 0x040) diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c index 942e1b1..0bc4e0c 100644 --- a/payloads/libpayload/drivers/usb/usb.c +++ b/payloads/libpayload/drivers/usb/usb.c @@ -272,7 +272,7 @@ bMaxPacketSize0 = 9; } return 1 << bMaxPacketSize0; - default: /* GCC is stupid and cannot deal with enums correctly */ + default: /* GCC is stupid and cannot deal with enums correctly */ return 8; } }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/arch/ar... File payloads/libpayload/arch/arm/virtual.c:
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/arch/ar... PS1, Line 58: * fault when accessed for the first time */ \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... File payloads/libpayload/curses/curses.h:
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 914: #define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 914: #define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 955: #define wstandout(win) (wattrset(win,A_STANDOUT)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 956: #define wstandend(win) (wattrset(win,A_NORMAL)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... File payloads/libpayload/curses/form/form.h:
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 115: unsigned short status; /* flags */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 153: void* (*copyarg)(const void *); /* copy fieldtype arg */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 153: void* (*copyarg)(const void *); /* copy fieldtype arg */ function definition argument 'const void *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 320: bool (* const prev_choice)(FIELD *,const void *)); space required after that ',' (ctx:OxV)
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... File payloads/libpayload/curses/form/fty_regex.c:
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 67: #define INIT register char *sp = RegEx_Init(instring); macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... File payloads/libpayload/curses/menu/m_global.c:
https://review.coreboot.org/c/coreboot/+/40123/1/payloads/libpayload/curses/... PS1, Line 72: ' ', /* Pad character */ please, no spaces at the start of a line
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40123
to look at the new patch set (#2).
Change subject: payloads: Remove unneeded whitespaces ......................................................................
payloads: Remove unneeded whitespaces
Change-Id: I9c9f4bdb3b43d0632ea53895278d5249da805ce3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M payloads/external/tint/Makefile M payloads/libpayload/arch/arm/cpu.S M payloads/libpayload/arch/arm/virtual.c M payloads/libpayload/crypto/sha1.c M payloads/libpayload/curses/PDCurses/dos/wccdos16.mak M payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak M payloads/libpayload/curses/PDCurses/os2/gccos2.mak M payloads/libpayload/curses/PDCurses/os2/iccos2.mak M payloads/libpayload/curses/PDCurses/os2/wccos2.mak M payloads/libpayload/curses/curses.h M payloads/libpayload/curses/form/form.h M payloads/libpayload/curses/form/fty_regex.c M payloads/libpayload/curses/menu/eti.h M payloads/libpayload/curses/menu/m_global.c M payloads/libpayload/drivers/serial/ipq806x.c M payloads/libpayload/drivers/usb/usb.c M payloads/libpayload/include/arm/arch/cache.h M payloads/libpayload/include/queue.h M payloads/libpayload/libc/getopt_long.c M payloads/libpayload/libc/qsort.c 20 files changed, 54 insertions(+), 54 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40123/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/arch/ar... File payloads/libpayload/arch/arm/virtual.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/arch/ar... PS2, Line 58: * fault when accessed for the first time */ \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/curses.h:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 914: #define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 914: #define getyx(win,y,x) (y = getcury(win), x = getcurx(win)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 955: #define wstandout(win) (wattrset(win,A_STANDOUT)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 956: #define wstandend(win) (wattrset(win,A_NORMAL)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/form/form.h:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 115: unsigned short status; /* flags */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 153: void* (*copyarg)(const void *); /* copy fieldtype arg */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 153: void* (*copyarg)(const void *); /* copy fieldtype arg */ function definition argument 'const void *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 320: bool (* const prev_choice)(FIELD *,const void *)); space required after that ',' (ctx:OxV)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/form/fty_regex.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 67: #define INIT register char *sp = RegEx_Init(instring); macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... File payloads/libpayload/curses/menu/m_global.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/curses/... PS2, Line 72: ' ', /* Pad character */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/ge... File payloads/libpayload/libc/getopt_long.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/ge... PS2, Line 83: #define INORDER (int)1 Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/qs... File payloads/libpayload/libc/qsort.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/qs... PS2, Line 43: size_t i = (n) / sizeof (TYPE); \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/libc/qs... PS2, Line 73: #define vecswap(a, b, n) if ((n) > 0) swapfunc(a, b, n, swaptype) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/drivers... PS2, Line 275: GCC is stupid and cannot deal with enums correctly is this still true ?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/40123/2/payloads/libpayload/drivers... PS2, Line 275: GCC is stupid and cannot deal with enums correctly
is this still true ?
Done
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40123 )
Change subject: payloads: Remove unneeded whitespaces ......................................................................
Abandoned
Merge conflict
-
build bot (Jenkins) (Code Review) -
HAOUAS Elyes (Code Review)