Change in coreboot[master]: soc/intel/jasperlake: Correct GPIO community PID configuration
Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41721 )
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation retuns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com
Change-Id: I3da4945e93605a297baff076295433164fdf613d --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/41721/1
diff --git a/src/soc/intel/jasperlake/acpi/gpio.asl b/src/soc/intel/jasperlake/acpi/gpio.asl index 60951f0..f8b180d 100644 --- a/src/soc/intel/jasperlake/acpi/gpio.asl +++ b/src/soc/intel/jasperlake/acpi/gpio.asl @@ -115,19 +115,19 @@ { Switch (ToInteger (Arg0)) { - Case (0) { + Case (COMM_0) { Local0 = PID_GPIOCOM0 } - Case (1) { + Case (COMM_1) { Local0 = PID_GPIOCOM1 } - Case (2) { + Case (COMM_2) { Local0 = PID_GPIOCOM2 } - Case (4) { + Case (COMM_4) { Local0 = PID_GPIOCOM4 } - Case (5) { + Case (COMM_5) { Local0 = PID_GPIOCOM5 } Default {
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41721
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation retuns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I3da4945e93605a297baff076295433164fdf613d --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/41721/2
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Subrata Banik, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41721
to look at the new patch set (#3).
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation returns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I3da4945e93605a297baff076295433164fdf613d --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/41721/3
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Subrata Banik, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41721
to look at the new patch set (#4).
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation retuns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com
Change-Id: I3da4945e93605a297baff076295433164fdf613d --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/41721/4
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Subrata Banik, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41721
to look at the new patch set (#5).
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation retuns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I3da4945e93605a297baff076295433164fdf613d --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/41721/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41721 )
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
Patch Set 5: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Subrata Banik, Patrick Rudolph, EricR Lai, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41721
to look at the new patch set (#6).
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation returns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I3da4945e93605a297baff076295433164fdf613d --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/41721/6
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41721 )
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41721 )
Change subject: soc/intel/jasperlake: Correct GPIO community PID configuration ......................................................................
soc/intel/jasperlake: Correct GPIO community PID configuration
Current implementation returns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify GPIO PM bits are correctly set through MS0x ACPI method.
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I3da4945e93605a297baff076295433164fdf613d Reviewed-on: https://review.coreboot.org/c/coreboot/+/41721 Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/jasperlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Maulik V Vaghela: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/acpi/gpio.asl b/src/soc/intel/jasperlake/acpi/gpio.asl index 60951f0..f8b180d 100644 --- a/src/soc/intel/jasperlake/acpi/gpio.asl +++ b/src/soc/intel/jasperlake/acpi/gpio.asl @@ -115,19 +115,19 @@ { Switch (ToInteger (Arg0)) { - Case (0) { + Case (COMM_0) { Local0 = PID_GPIOCOM0 } - Case (1) { + Case (COMM_1) { Local0 = PID_GPIOCOM1 } - Case (2) { + Case (COMM_2) { Local0 = PID_GPIOCOM2 } - Case (4) { + Case (COMM_4) { Local0 = PID_GPIOCOM4 } - Case (5) { + Case (COMM_5) { Local0 = PID_GPIOCOM5 } Default {
-
Aamir Bohra (Code Review) -
EricR Lai (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)