Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/15474 )
Change subject: AMD fam10: Remove HAVE_ACPI_RESUME support ......................................................................
Patch Set 12: Code-Review+2
Patch Set 12:
Patch Set 12:
Patch Set 12:
Patch Set 12:
Patch Set 12:
This might ease up the path should anyone attempt to bring fam10 to next release requirements.
The latest info I have is asus/kcma-d8 not working and asus/kgpe-d16 working in 4.6 but very slowly. For neither systems, no resume logs have been brought to my knowledge for 12 months.
https://mail.coreboot.org/pipermail/coreboot/2018-June/086906.html
asus/kfsn4-dre booted up fine last week with master (and rather fast). Did not test s3resume though. Can retest next week if desired.
Next week it may be gone ;)
Arthur has pending (abandoned?) work to get these to RELOCATABLE_RAMSTAGE=y.
Right, "next week" means Monday, so I hope I don't arrive late...
S3 resume is only implemented on the ddr3 codepath and at the moment only on asus/{kcma-d8,kgpe-d16}. The issue with relocatable ramstage on amdfam10 is that you have to sync the TOP_MEM MSR on the AP's before CPU MP init in ramstage (otherwise the code and stack are placed above the TOP_MEM of the AP's which locks the system as soon as it tries to run that code). At this point I'm not working on that anymore. See https://review.coreboot.org/c/coreboot/+/30063
Just noticed that KFSN4-DRE indeed lacks S3 support. Welp.
-
Angel Pons (Code Review)