Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/soc/mediatek/mt8196/thermal_sram.c:
https://review.coreboot.org/c/coreboot/+/86017/comment/197b86db_54622e12?usp... :
PS5, Line 46: uint32_t pattern = 0xffffffff;
Upper case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86017?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieef94a6909e4da82461351bcb9292e9d01db3362
Gerrit-Change-Number: 86017
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Sat, 18 Jan 2025 04:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes